From: Christian Couder <christian.couder@gmail.com>
Date: Mon, 16 Feb 2026 09:23:16 GMT
Subject: Re: [PATCH 0/4] Fix tests with missing iconv(1) executable
Message-ID: <CAP8UFD0=7sCe6oEG33gb8Gzug_ig4m-breNJeUbBk1AUvuaR4w@mail.gmail.com>
In-Reply-To: <20260209-b4-pks-ci-msvc-iconv-fixes-v1-0-1e3167cd8828@pks.im>

On Mon, Feb 9, 2026 at 1:42 PM Patrick Steinhardt <ps@pks.im> wrote:
>
> Hi,
>
> I recently noticed that th MSVC-based tests in GitLab CI started to

s/that th/that the/

> fail. The root cause is that the iconv(1) executable cannot be found on
> this platform anymore. This isn't entirely surprising: we depend on the
> Git for Windows environment to provide necessary shell tools, and that
> environment of course is not a fully fledged MSYS2 installation.

Maybe this and perhaps some commit messages of the patches in the
series could also talk about
https://github.com/git-for-windows/git/issues/6083 a bit now that we
know it's related.

Except for this and the documentation issue in the build system I
mentioned in my previous email, the patches in the series look good to
me.

Thanks.