From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 26 Oct 2012 15:44:13 GMT
Subject: Re: [PATCH] Fix git p4 sync errors
Message-ID: <CAP8UFD0+FPDERfkTeJWuq=T6RQ65yjHwbhTP_SYv6aA+1xq32Q@mail.gmail.com>
In-Reply-To: <F0F92B0A-D37F-40D4-A0DF-43EEDA2818B9@gmail.com>

Hi,

On Thu, Oct 25, 2012 at 4:41 AM, Matt Arsenault <arsenm2@gmail.com> wrote:
>
> On Oct 21, 2012, at 12:06 , Junio C Hamano <gitster@pobox.com> wrote:
>>
>> - Why is it a bug not to pass "-s"?  How does the bug happen?
>
> I encountered this one time after using it for months. One day I couldn't git p4 rebase
> with the key error.  I searched for the error and found some version of git-p4 that fixed
> a similar error by adding the -s to describe. Adding the -s fixed the error and
> everything seemed to be working correctly.

The perforce documentation says the following about this flag:

"The -s flag omits the diffs of files that were updated."

So if the diffs are not used, there is no downside to use -s.
Maybe the patch should just state this.

Best,
Christian.