From: Blake Burkhart Date: Thu, 03 Nov 2016 00:41:16 GMT Subject: Re: [PATCH] transport: add core.allowProtocol config option Message-ID: In-Reply-To: <20161103002225.GA13369@google.com> Thanks for CCing me. I haven't looked at this implementation in detail, but it would be good to move this configuration into the config system because I think we can more easily provide a default safe configuration. It would be nice to use this to introduce a default list of whitelisted protocols that even applies to `git clone`. I strongly think we need to find a way to have git-remote-ext disabled by default. This could be a way to do it. On Wed, Nov 2, 2016 at 7:22 PM, Jonathan Nieder wrote: > That reminds me: external tools also set GIT_ALLOW_PROTOCOL when the > user hasn't set it explicitly, like git-submodule.sh does. E.g. > repo , > mercurial . > Other external tools consume GIT_ALLOW_PROTOCOL, like 'go get' > . > Can we make it more convenient for them to support this configuration > too? Most of these are my fault too. I encouraged git-repo and mercurial to use GIT_ALLOW_PROTOCOL to avoid security issues from git-remote-ext. -- Blake Burkhart