From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Fri, 04 Sep 2015 21:10:52 GMT
Subject: Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables
Message-ID: <CAOxFTczPD00rw3nmaYjM=afXez_07p8kM28XY__opLKsVOaWxg@mail.gmail.com>
In-Reply-To: <xmqqpp1yf3qe.fsf@gitster.mtv.corp.google.com>

On Fri, Sep 4, 2015 at 8:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> It shouldn't be necessary for $GIT_DIR, but it makes sense for other git
>> variables. E.g., with "AcceptEnv GIT_*", "git -c" config is propagated.
>> E.g.:
>> ...
>
> Just to make sure I got you correctly, you are saying that "we
> propagate, but that is not correct. We should stop doing so", right?

Indeed, we should not propagate them. For what we know so far, at
least GIT_DIR and GIT_WORK_TREE should be removed from the ssh
environment, in case the remote server has AcceptEnv GIT_* and an
older git version.

-- 
Giuseppe "Oblomov" Bilotta