From: Giuseppe Bilotta Date: Thu, 26 Jan 2017 18:18:31 GMT Subject: Re: [PATCH] rebase: pass --signoff option to git am Message-ID: In-Reply-To: On Mon, Jan 23, 2017 at 9:03 PM, Giuseppe Bilotta wrote: > On Mon, Jan 23, 2017 at 7:13 PM, Junio C Hamano wrote: >> >> Should we plan to extend this to the interactive backend that is >> shared between rebase -i and rebase -m, too? Or is this patch >> already sufficient to cover them? > > AFAIK this is sufficient for both, in the sense that I've used it with > git rebase -i and it works. Hm, something very strange is going on, I've just tested the patch on top of current next and for some reason the signoff line does not get added. The command-line option gets passed to git am, but I get no signoff for some reason, so something is failing down the line, I'll have to investigate. -- Giuseppe "Oblomov" Bilotta