From: Adam Spiers <git@adamspiers.org>
Date: Fri, 28 Dec 2012 21:15:40 GMT
Subject: Re: [PATCH v3 16/19] pathspec.c: move reusable code from builtin/add.c
Message-ID: <CAOkDyE_706JwjY24xHvyMb1YGNhJOo_L3T8+V4hHgDJYxdLeiA@mail.gmail.com>
In-Reply-To: <7vy5ghhpi0.fsf@alter.siamese.dyndns.org>

On Fri, Dec 28, 2012 at 8:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Adam Spiers <git@adamspiers.org> writes:
>
>> diff --git a/pathspec.c b/pathspec.c
>> new file mode 100644
>> index 0000000..8aea0d2
>> --- /dev/null
>> +++ b/pathspec.c
>> @@ -0,0 +1,99 @@
>> +#include "cache.h"
>> +#include "dir.h"
>> +#include "pathspec.h"
>> +
>> +void fill_pathspec_matches(const char **pathspec, char *seen, int specs)
>> +{
>
> It did not matter while it was an implementation detail of "git
> add", but as a public function, something needs to clarify that this
> "fill"s matches *against the index*, not against a tree or the files
> in the current directory.  The same comment applies to all the
> internal functions this patch exposes to the outside world.

Prior to submitting the v3 series, I attempted to understand
fill_pathspec_matches() and find_used_pathspec() well enough to
document them all, but I failed.  Perhaps some kind soul could explain
what is the exact purpose of these functions, and in particular the
role of char *seen in both?