From: Xin Li Date: Thu, 28 May 2020 19:12:19 GMT Subject: Re: [PATCH v2 1/1] fetch: allow adding a filter after initial clone. Message-ID: In-Reply-To: <20200528171924.GC58643@google.com> On Thu, May 28, 2020 at 10:19 AM Jonathan Nieder wrote: > > Junio C Hamano wrote: > > > It would be safe to upgrade version 0 repository when there is *no* > > existing configuration variable in the "extension" section, > > Yes, that makes sense (also for the case Brian mentioned where someone > may try setting extension.objectFormat, see no effect, and then forget > about it). I see that's a good point I found that the current code doesn't really check repositoryformatversion for e.g. partialclone, so without setting repositoryformatversion to 1, just setting extensions.partialclone = origin will still make fetch --filter work and some test cases are depending on this, do we want to keep this feature/bug? I have added some additional checks to my local git version and found that we would also need to fix a lot of test cases for worktree, etc. if we would enforce the check.