From: Roy E Date: Wed, 11 Dec 2024 06:21:38 GMT Subject: Re: [PATCH v3 6/7] git-submodule.sh: improve variables readability Message-ID: In-Reply-To: Junio C Hamano wrote: > Roy Eldar writes: > > > + -b* | --branch*) > > + branch="$1" > > Once another option like "--branches-only" will be caught by this > case arm. Do not omit "=" in the pattern. Thanks. I noticed that I did so in a couple of other places as well, so I'll fix that and send a v4 patch series.