From: Edmundo Carmona Antoranz Date: Tue, 17 Nov 2015 23:47:01 GMT Subject: Re: [PATCH v2] blame: avoid checking if a file exists on the working tree if a revision is provided Message-ID: In-Reply-To: On Tue, Nov 17, 2015 at 5:37 PM, Edmundo Carmona Antoranz wrote: > So, do I forget about the blame patch (given that I'm not fixing an > advertised syntax, even if it's supported) and fix annotate instead or > do I fix both? And if I should swing for both, do I create a single > patch or a chain of two patches, one for each builtin? Actually, cmd_annotate will call cmd_blame so this patch actually fixes annotate as well (nice unintended consequence). So I guess it will be a single patch. Let me work on the tests and then I'll send a patch that will hopefully cover all raised points. Cheers!