From: Koji Nakamaru <koji.nakamaru@gree.net>
Date: Wed, 18 Feb 2026 19:11:40 GMT
Subject: Re: [PATCH v3] osxkeychain: define build targets in the top-level Makefile.
Message-ID: <CAOTNsDyVqooYkSXv3U-SwAqiSqTnwDCOXpRr9AZjgbv5P=dbqw@mail.gmail.com>
In-Reply-To: <11a91368-7dc8-4081-bd13-d208126beb7b@app.fastmail.com>

On Thu, Feb 19, 2026 at 1:10 AM Kristoffer Haugsbakk
<kristofferhaugsbakk@fastmail.com> wrote:
>
> On Wed, Feb 18, 2026, at 06:14, Koji Nakamaru via GitGitGadget wrote:
> > From: Koji Nakamaru <koji.nakamaru@gree.net>
> >
> > The fix for git-credential-osxkeychain in 4580bcd235 (osxkeychain: avoid
> > incorrectly skipping store operation) introduced linkage with libgit.a,
>
> Nitpick: Commit references should have the date:
>
>     4580bcd235 (osxkeychain: avoid incorrectly skipping store operation, 2025-11-14)
>
> Like the rest of the commits you reference here.
>
> > and its Makefile was adjusted accordingly. However, the build fails as
> > of 864f55e190 because several macOS-specific refinements were applied to
> > the top-level Makefile and config.mak.uname, such as:
> >
> >   - 363837afe7 (macOS: make Homebrew use configurable, 2025-12-24)
> >   - cee341e9dd (macOS: use iconv from Homebrew if needed and present,
> >     2025-12-24)
> >   - d281241518 (utf8.c: enable workaround for iconv under macOS 14/15,
> >     2026-01-12)
> >[snip]

I see. I'll fix the commit message in the next reroll.

--
Koji Nakamaru