From: Karthik Nayak <karthik.188@gmail.com>
Date: Sat, 10 Oct 2015 18:19:10 GMT
Subject: Re: [PATCH v2 07/10] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams
Message-ID: <CAOLa=ZTvD5cXduPH3G0bGDba_hevLQsuwYsoZFtmfTd2SS4Prw@mail.gmail.com>
In-Reply-To: <vpqa8rtnqzp.fsf@grenoble-inp.fr>

On Fri, Oct 9, 2015 at 12:10 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> --- a/ref-filter.c
>> +++ b/ref-filter.c
>> @@ -1118,8 +1118,10 @@ static void populate_value(struct ref_array_item *ref)
>>                               char buf[40];
>>
>>                               if (stat_tracking_info(branch, &num_ours,
>> -                                                    &num_theirs, NULL))
>> +                                                    &num_theirs, NULL)) {
>> +                                     v->s = "[gone]";
>
> My remark about translation still holds. The string was previously
> translated in "branch" and you are removing this translation (well, not
> here, but when 09/10 starts using this code).
>

I should have mentioned in my cover letter, I didn't really understand
what has to be done about this, couldn't find much reference to go
about this. What do you suggest?

-- 
Regards,
Karthik Nayak