From: Karthik Nayak <karthik.188@gmail.com>
Date: Fri, 10 Jul 2015 11:11:52 GMT
Subject: Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern
Message-ID: <CAOLa=ZTr=C49K4d_zdD56mGoiiKKO_M35cagvTfCz06paxh=ew@mail.gmail.com>
In-Reply-To: <vpq8uap78xu.fsf@anie.imag.fr>

On Thu, Jul 9, 2015 at 7:02 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Since 'ref-filter' only has an option to match path names
>> add an option for regular pattern matching.
>
> Here also, a hint on why this is needed would be welcome.
>

Will add.

>> --- a/ref-filter.c
>> +++ b/ref-filter.c
>> @@ -956,6 +956,20 @@ static int commit_contains(struct ref_filter *filter, struct commit *commit)
>>
>>  /*
>>   * Return 1 if the refname matches one of the patterns, otherwise 0.
>> + * A pattern can be a literal prefix (e.g. a refname "refs/heads/master"
>> + * matches a pattern "refs/heads/m") or a wildcard (e.g. the same ref
>> + * matches "refs/heads/m*",too).
>
> Missing space after , (same in the hunk context below)
>

Noted. Thanks :)

-- 
Regards,
Karthik Nayak