From: Karthik Nayak Date: Tue, 20 Oct 2026 18:32:07 GMT Subject: Re: [PATCH 2/7] setup: introduce object storage extension Message-ID: In-Reply-To: Junio C Hamano writes: > Karthik Nayak writes: > >>> diff --git a/odb/source.c b/odb/source.c >>> index b25ef14df8..10abe33a26 100644 >>> --- a/odb/source.c >>> +++ b/odb/source.c >>> @@ -1,4 +1,5 @@ >>> #include "git-compat-util.h" >>> +#include "gettext.h" >>> #include "object-file.h" >>> #include "odb/source-files.h" >>> #include "odb/source.h" >> >> Do we need this import? This commit seems to compile without it. > > It is better to be explicit, rather than relying on an indirect > inclusion from an unrelated header. Since odb/source.c is more > or less a library-like part of the system, however, the presence > of translatable messages meant for human users is a bit of a > curiosity. Ah! it's for the '_()' translation, I missed that. Makes sense. Thanks