From: Karthik Nayak <karthik.188@gmail.com>
Date: Sun, 11 Oct 2015 18:38:10 GMT
Subject: Re: [PATCH v2 00/10] port branch.c to use ref-filter's printing options
Message-ID: <CAOLa=ZTjuuO_TmdynQvJGVtQHZokwDpqZLUOWgCx-_UO=JKvvw@mail.gmail.com>
In-Reply-To: <vpq4mhx2x5z.fsf@grenoble-inp.fr>

On Sun, Oct 11, 2015 at 9:51 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Also does it make sense to integrate these changes here? Or would you like to
>> have another series on this?
>
> To me, the important in this series is to avoid introducing duplicated
> and inconsistent code, because it would make further refactoring harder.
>

Would you suggest duplicating whats done with %(align) here?

> But this series starts getting close to finished, so you should not try
> to add to much to it (at least for me: I spend some time reviewing v2
> and I have an idea of what the interdiff should look like, I'd rather
> avoid having new distraction in the v2->v3 interdiff).
>

Yes! makes sense, thanks :)

-- 
Regards,
Karthik Nayak