From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 08 Oct 2026 09:24:28 GMT
Subject: Re: [PATCH v2 00/13] odb/source-files: move alternates into the backend
Message-ID: <CAOLa=ZTjrzNbuvZ-kr6k5TZSMyGGMFTb4iar6DZwdnCDvUrH9Q@mail.gmail.com>
In-Reply-To: <20261008-pks-odb-move-alternates-v2-0-b47e8189baa5@pks.im>

Patrick Steinhardt <ps@pks.im> writes:
[snip]

> Range-diff versus v1:
>
>  1:  985b068271 !  1:  43a288604d commit-graph: require resolved packfile paths for `stdin_packs`
>     @@ Commit message
>          for a set of packfiles via the "--stdin-packs" option. Those users are
>          expected to pass in relative paths, and those eventually get resolved in
>          `fill_oids_from_packs()`. This ties the logic in "commit-graph.c" to the
>     -    specific object database source.
>     +    specific object database source, as the subsystem now needs to assume
>     +    where a specific packfile is located relative to the source itself.
>
>          Refactor the logic to instead require the caller to pass in resolved
>     -    packfiles to untangle that dependency.
>     +    packfiles to untangle that dependency. This also makes the next change
>     +    easier to implement, where we'll get rid of passing the source to the
>     +    commit-graph subsystem.
>
>          Signed-off-by: Patrick Steinhardt <ps@pks.im>

This looks good, the previous version itself was in great shape. I have
nothing more to add :)

[snip]