From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 23 Sep 2025 15:30:06 GMT
Subject: Re: [PATCH 2/4] builtin/repo: add object counts in stats output
Message-ID: <CAOLa=ZTihUt0d-3_LOydX4GxWPSquAOWkzw3+0XzM-zp6wFZ+w@mail.gmail.com>
In-Reply-To: <20250923025700.3046260-3-jltobler@gmail.com>

Justin Tobler <jltobler@gmail.com> writes:

[snip]

> @@ -159,13 +161,25 @@ static int repo_info(int argc, const char **argv, const char *prefix,
>  	return print_fields(argc, argv, repo, format);
>  }
>
> -struct stats {
> +struct ref_stats {
>  	size_t branches;
>  	size_t remotes;
>  	size_t tags;
>  	size_t others;
>  };
>
> +struct object_stats {
> +	size_t tags;
> +	size_t commits;
> +	size_t trees;
> +	size_t blobs;
> +};
> +
> +struct stats {
> +	struct ref_stats refs;
> +	struct object_stats objects;
> +};
> +

Okay so we do use nested structs, which I mentioned in the previous
commit, so we're all good.

Nit: A lot of the diff in this commit is because we don't make the
required structs in the previous commit. Perhaps we could start with the
nested structs in the previous commit? That way this patch would be much
simpler.

[snip]