From: Karthik Nayak <karthik.188@gmail.com>
Date: Sat, 31 May 2025 21:25:58 GMT
Subject: Re: [PATCH v3 06/10] t/test-lib: fix TAP format for BASH_XTRACEFD warning
Message-ID: <CAOLa=ZTgUbfdtb+R_kLps-=75=euzoMDi1OSM9O5XL_3irAZxg@mail.gmail.com>
In-Reply-To: <20250530-pks-meson-tap-v3-6-676f5e41f2e4@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> When the Bash version is too old to support BASH_XTRACEFD we print a
> warning to stderr. This warning breaks the TAP format because it is not
> prefixed with a "#". Fix this.
>

Nit: The important bit here is that TAP treats anything that starts with a
'#' as a comment. Everything else is parsed. Since this is warning which
shouldn't be parsed, we add the '#'. Perhaps worthwhile adding this
extra context to the commit. Anyways not worth a re-roll.

[snip]