From: karthik nayak Date: Tue, 16 Jun 2015 16:01:21 GMT Subject: Re: [PATCH v3 01/11] t6301: for-each-ref tests for ref-filter APIs Message-ID: In-Reply-To: On Tue, Jun 16, 2015 at 8:51 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> Add tests for 'for-each-ref' which utilizes the ref-filter APIs. >> Currently it's redundant with the tests in 't6300' but more tests >> will be eventually added as we implement more options into >> 'for-each-ref'. > > Actually, I'm not convinced that the actual tests have a real value > (since as you say, it's redundant with t6300). Perhaps we can limit this > commit to the setup. > Well I just wanted some minimal tests, but yeah, we could limit this only to the setup. >> +++ b/t/t6301-for-each-ref-filter.sh >> @@ -0,0 +1,36 @@ >> +#!/bin/sh >> + >> +test_description='test for-each-refs usage of ref-filter APIs' >> + >> +. ./test-lib.sh >> +. "$TEST_DIRECTORY"/lib-gpg.sh > > You are not using lib-gpg.sh, right? > > If first thought it was an incorrect cut-and-paste, but I actually think > that you need to setup a signed tag to properly test the --points-at > option (it does not only list refs pointing directly at a commit, but > also refs pointing at a tag pointing at the given commit). > > Such signed tag could be added here and used later in PATCH 04. > It is a cut-paste error. Thanks will look into it. -- Regards, Karthik Nayak