From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 06 Oct 2026 11:57:06 GMT
Subject: Re: [PATCH] builtin/repo: rename "references.format" to "references.storageFormat"
Message-ID: <CAOLa=ZTULXyr0+rdByroEjs1ncjjt3w66z7enOprJ=7gPY64JQ@mail.gmail.com>
In-Reply-To: <asSM12B35oka08Nu@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> On Mon, Oct 05, 2026 at 03:11:19PM +0000, Karthik Nayak wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>>
>> > As part of 2f28db44d5 (Merge branch 'ps/ref-storage-format', 2026-10-01)
>> > we have adapt all sites that used to say "reference format" to instead
>> > say "reference storage format".
>> >
>> > One missed spot though was in git-repo(1), where we still print the
>> > "references.format" key. Fix that oversight by renaming the key to
>> > "references.storageFormat".
>>
>> The patch looks good, but this does break backward compatibility. But
>> since the command it marked as experimental, this should be okay.
>
> Right, I should've probably mentioned this as part of the commit
> message. We could for a while carry both keys of course. But given that
> it's marked as experimental I think it's okay to break the format and
> drop the old key.
>
> Thanks!
>
> Patrick

Yeah, all good, no need to iterate just for that I think.