From: Karthik Nayak <karthik.188@gmail.com>
Date: Sun, 13 Sep 2015 13:22:38 GMT
Subject: Re: [PATCH v4 4/8] branch: move 'current' check down to the presentation layer
Message-ID: <CAOLa=ZTQjtEi4G7_T6gRzrmL=EocJxw69qR=n7vjLWCvbu2JMw@mail.gmail.com>
In-Reply-To: <vpq4miyv7kn.fsf@anie.imag.fr>

On Sun, Sep 13, 2015 at 5:45 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> We check if given ref is the current branch in print_ref_list(). Move
>> this check to print_ref_item() where it is checked right before
>> printing.
>
> You may want to add a sentence saying why this is good. Given the
> context, it's relatively clear that this makes the code closer to the
> shape expected by ref-filter, but if you imagine someone bisecting or
> blaming and finding this commit in another context, that person may
> appreciate more explanation.
>

Will do.

-- 
Regards,
Karthik Nayak