From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 07 Aug 2025 07:48:35 GMT
Subject: Re: [GSoC PATCH v8 0/5] repo: add new command for retrieving repository info
Message-ID: <CAOLa=ZT9BvAp_TvD3MnUJxtpmT=U=hzi3NapokWbEyvyrv_y3A@mail.gmail.com>
In-Reply-To: <20250806195537.93302-1-lucasseikioshiro@gmail.com>

Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:

> Hi again!
>
> This 8th version of `git-repo` basically address minor issues from the 7th
> version:
>
> - A test wasn't passing in the CI because it assumed that the ref
>   format was files by default. I fixed that.
>
> - t0450 wasn't passing because the documentation didn't match the
>   usage string. I fixed that.
>
> - A test generated the output and the expected value but wasn't
>   comparing them. I also fixed that.
>
> - strbuf management: now we have two strbufs for printing values:
>   one for unquoted values and other for quoted values
>
> - Test codestyle: now it's ending test case liness with \ instead of
>   open strings
>
> - Documentation: this version documents that we escape the value in
>   the `keyvalue` format.
>

Apart from a single nit on my side, I couldn't find any other changes
needed, this version looks good! :)

[snip]