From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 06 Jun 2024 10:07:45 GMT
Subject: Re: [PATCH 06/29] merge-recursive: fix leaging rename conflict info
Message-ID: <CAOLa=ZT3XvdpheQCV9VQinnppitU3ghqvB_Qs-+zm0OyrAOrSQ@mail.gmail.com>
In-Reply-To: <0052d60ee889981f2ba92c9781e1659e961eace4.1717402439.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

In the subject:

s/leaging/leaking

> When computing rename conflicts in our recursive merge algorithm we set
> up `struct rename_conflict_info`s to track that information. We never
> free those data structures though and thus leak memory.
>
> We need to be a bit more careful here though because the same rename
> conflict info can be assigned to multiple structures. Accomodate for

Nit: s/Accomodate/Accommodate

[snip]