From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 06 Mar 2025 14:16:53 GMT
Subject: Re: [PATCH v4 12/16] refs/iterator: implement seeking for reftable iterators
Message-ID: <CAOLa=ZT1ZVKGQ2KLiZY14hRH2qobaz6=V6qNXjcLkwhRvZPEnw@mail.gmail.com>
In-Reply-To: <20250228-pks-update-ref-optimization-v4-12-6425c04268b5@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Implement seeking of reftable iterators. As the low-level reftable
> iterators already support seeking this change is straight-forward. Two
> notes though:
>
>   - We do not support seeking on reflog iterators. It is unclear what
>     seeking would even look like in this context, as you typically would
>     want to seek to a specific entry in the reflog for a specific ref.
>     There is not currently a usecase for this, but if there ever is we
>     can implement seeking in the future.
>

Nit: This last sentence reads a little weird, perhaps:

  There is currently no use case for this, but if one arises in the
  future, we can implement seeking.

>   - We start to check whether `reftable_stack_init_ref_iterator()` is
>     successful.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  refs/reftable-backend.c | 35 ++++++++++++++++++++++++++++++-----
>  1 file changed, 30 insertions(+), 5 deletions(-)
>

The patch looks good.

[snip]