From: Karthik Nayak <karthik.188@gmail.com>
Date: Sat, 25 Jul 2015 04:15:21 GMT
Subject: Re: [PATCH v4 02/10] ref-filter: make the 'color' use ref_formatting_state
Message-ID: <CAOLa=ZT0LALR0gQaRfVnpyhScSKrSLP+QPQioe+uEH+KJYs=Ow@mail.gmail.com>
In-Reply-To: <xmqq1tfxkz44.fsf@gitster.dls.corp.google.com>

On Sat, Jul 25, 2015 at 3:16 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Make color which was considered as an atom, to use
>> ref_formatting_state and act as a pseudo atom. This allows
>> interchangeability between 'align' and 'color'.
>>
>> Helped-by: Junio C Hamano <gitster@pobox.com>
>> Mentored-by: Christian Couder <christian.couder@gmail.com>
>> Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>
> I think 1/10 and 2/10 are the other way around.  Preferably, these
> would be three patches, in this order:
>
>  (1) prepare the "formatting state" and pass it around; no other
>      code change.
>
>  (2) have "color" use that facility.
>
>  (3) add a new feature using that facility.
>
> The first two may want to be combined into a single patch, if it
> does not make the patch too noisy.
>

Ill reverse the patches and merge the first two as you suggested.
Thanks

-- 
Regards,
Karthik Nayak