From: Karthik Nayak <karthik.188@gmail.com>
Date: Wed, 06 Jan 2016 10:17:59 GMT
Subject: Re: [PATCH v3 11/15] ref-filter: convert variable 'width' to an unsigned int
Message-ID: <CAOLa=ZT=_t62eKpkPbf+5k9TC0MoeN63+nwVTWLccG0rJF09kQ@mail.gmail.com>
In-Reply-To: <xmqqmvsjivcv.fsf@gitster.mtv.corp.google.com>

On Wed, Jan 6, 2016 at 2:42 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> In align_atom_parser() the 'width' variable is an int, which requires
>> an explicit type conversion when used in strtoul_ui(). Hence make it
>> an unsigned int.
>>
>> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
>> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
>> ---
>
> Shouldn't this be done in [09/15] from the beginning?  As it's not
> like [09/15] was a pure code movement, this step looks like "Oops,
> I screwed up earlier, and here is a fixup".
>
> If we want to do this as a separate step, it would be easier to
> follow if it is done _before_ 09/15 to the original of the code
> movement, I think.
>

Haha, does seem that way. Will merge it in.

-- 
Regards,
Karthik Nayak