From: Karthik Nayak <karthik.188@gmail.com>
Date: Sat, 11 Jul 2015 05:55:44 GMT
Subject: Re: [PATCH v2 05/10] ref-filter: add option to match literal pattern
Message-ID: <CAOLa=ZT+59dcCW+QHhvK8Wp5Q_1YhkfCxV0=PirOWtVKWFCvCw@mail.gmail.com>
In-Reply-To: <xmqqfv4wklph.fsf@gitster.dls.corp.google.com>

On Fri, Jul 10, 2015 at 10:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Since 'ref-filter' only has an option to match path names
>> add an option for regular pattern matching.
>
> There is nothing "regular" about the pattern matching you are
> adding.
>
> Everywhere else we use patterns on refs we call wildmatch(), which
> is an enhanced implementation of fnmatch(3), and you are doing the
> same in this new codepath.
>
> Just drop that word from here (and if you said something similar in
> the documentation, drop "regular" ffrom there as well).  It would
> invite confusion with regular expression matching, which we will not
> do for refs.

Ok, will do. Thanks

-- 
Regards,
Karthik Nayak