From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 10 Mar 2025 21:11:06 GMT
Subject: Re: [GSOC PATCH v2 1/2] environment: move access to "core.attributesfile" into repo settings
Message-ID: <CAOLa=ZSqgzLv=X9=7kFFeA+w_PsPwYz6iJyeqW=i4yrrszURBg@mail.gmail.com>
In-Reply-To: <20250310151048.69825-2-ayu.chandekar@gmail.com>

Ayush Chandekar <ayu.chandekar@gmail.com> writes:

[snip]

> diff --git a/repo-settings.h b/repo-settings.h
> index ddc11967e0..58dadd9dae 100644
> --- a/repo-settings.h
> +++ b/repo-settings.h
> @@ -66,6 +66,7 @@ struct repo_settings {
>  	size_t packed_git_limit;
>
>  	char *hooks_path;
> +	char *git_attributes_file;
>  };
>  #define REPO_SETTINGS_INIT { \
>  	.shared_repository = -1, \
> @@ -92,5 +93,7 @@ const char *repo_settings_get_hooks_path(struct repository *repo);
>  int repo_settings_get_shared_repository(struct repository *repo);
>  void repo_settings_set_shared_repository(struct repository *repo, int value);
>  void repo_settings_reset_shared_repository(struct repository *repo);
> +/* Read the value for "core.attributesfile". */

Nit: Shouldn't we also mention that we default to
`xdg_config_home("attributes")` if the 'core.attributesfile' value isn't
available?

> +const char *repo_settings_get_attributesfile_path(struct repository *repo);
>
>  #endif /* REPO_SETTINGS_H */
> --
> 2.48.GIT