From: Karthik Nayak Date: Sun, 30 Aug 2015 06:51:52 GMT Subject: Re: [PATCH v14 05/13] ref-filter: add option to filter out tags, branches and remotes Message-ID: In-Reply-To: On Sun, Aug 30, 2015 at 9:00 AM, Eric Sunshine wrote: > On Sat, Aug 29, 2015 at 10:12 AM, Karthik Nayak wrote: >> Add a function called 'for_each_fullref_in()' to refs.{c,h} which >> iterates through each ref for the given path without trimming the path >> and also accounting for broken refs, if mentioned. >> >> Add 'filter_ref_kind()' in ref-filter.c to check the kind of ref being >> handled and return the kind to 'ref_filter_handler()', where we >> discard refs which we do not need and assign the kind to needed refs. >> >> Signed-off-by: Karthik Nayak >> --- >> diff --git a/refs.c b/refs.c >> index 4e15f60..a9469c2 100644 >> --- a/refs.c >> +++ b/refs.c >> @@ -2108,6 +2108,15 @@ int for_each_ref_in(const char *prefix, each_ref_fn fn, void *cb_data) >> return do_for_each_ref(&ref_cache, prefix, fn, strlen(prefix), 0, cb_data); >> } >> >> +int for_each_fullref_in(const char *prefix, each_ref_fn fn, void *cb_data, unsigned int broken) > > Booleans such as 'broken' are typically declared 'int' in this > codebase, rather than 'unsigned int'. > But doesn't it make more sense to have it as unsigned, since its values are either 0 or 1? -- Regards, Karthik Nayak