From: Karthik Nayak Date: Thu, 27 Aug 2026 10:03:08 GMT Subject: Re: [PATCH 02/10] builtin/fsck: merge `fsck_obj_buffer()` and `fsck_obj()` Message-ID: In-Reply-To: <20260825-pks-odb-source-fsck-v1-2-b756de0bf24f@pks.im> Patrick Steinhardt writes: > The interfaces of the functions `fsck_obj()` and `fsck_obj_buffer()` are > somewhat similar to one another. The only difference between those two > is that `fsck_obj()` takes an already-parsed object as input, whereas > `fsck_obj_buffer()` parses the buffer and then calls `fsck_obj()`. > > Furthermore, `fsck_obj()` has no callers other than `fsck_obj_buffer()`. > > Refactor the code by merging those two functions. This makes it obvious > which function does what, and it allows us to get rid of the early in s/early/early return/ ? > `fsck_obj()` in case `SEEN` is set as the only caller unconditionally > clears that bit before calling it anyway. > > Signed-off-by: Patrick Steinhardt > --- > builtin/fsck.c | 47 ++++++++++++++++++++--------------------------- > 1 file changed, 20 insertions(+), 27 deletions(-) > The patch looks good!