From: Karthik Nayak Date: Fri, 07 Mar 2025 10:48:55 GMT Subject: Re: What's cooking in git.git (Feb 2025, #09; Fri, 28) Message-ID: In-Reply-To: Junio C Hamano writes: > shejialuo writes: > >> On Fri, Feb 28, 2025 at 04:45:31PM -0800, Junio C Hamano wrote: >> >>> * sj/ref-consistency-checks-more (2025-02-27) 9 commits >>> - builtin/fsck: add `git refs verify` child process >>> - packed-backend: check whether the "packed-refs" is sorted >>> - packed-backend: add "packed-refs" entry consistency check >>> - packed-backend: check whether the refname contains NUL characters >>> - packed-backend: add "packed-refs" header consistency check >>> - packed-backend: check if header starts with "# pack-refs with: " >>> - packed-backend: check whether the "packed-refs" is regular file >>> - builtin/refs: get worktrees without reading head information >>> - t0602: use subshell to ensure working directory unchanged >>> >>> "git fsck" becomes more careful when checking the refs. >>> >>> Comments? >>> source: >> >> I think I have addressed the comments from you, Patrick and Karthik. >> Could we make the patch into "next"? > > Mine was merely a small kibitzing on the logic flow structure, and I > didn't really looked at the larger picture beyond that part of the > code I looked at. Let's hear from Patrick and Karthik (cc'ed) if > they find the result of the updates satisfactory. > Sorry I missed this email. I did review an earlier version of the series and it did look good to me, haven't reviewed the latest version (but that's not a blocker from my side). > Thanks.