From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 08 Sep 2026 09:22:50 GMT
Subject: Re: [PATCH v7 3/4] receive-pack: move message generation to separate function
Message-ID: <CAOLa=ZS__CA3AhBTR+ndW=fJN1bA9VLa0v87eZ4ja+NN6vc9WA@mail.gmail.com>
In-Reply-To: <xmqq1pb43hjh.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> -static void report(struct command *commands, const struct strbuf *unpack_status)
>> +/*
>> + * Generate the response to be sent to the client invoking 'git-receive-pack(1)'.
>> + * For v2 protocol, set `detailed_report` to true, which will also add detailed
>> + * report per reference update.
>> + */
>
> The second sentence is stale and no longer matches the interface.
>

Will drop.

>> +static void generate_report(struct strbuf *buf, struct command *commands,
>> +			    const struct strbuf *unpack_status,
>> +			    enum report_status_version version)
>>  {