From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 04 Jun 2024 08:23:09 GMT
Subject: Re: [PATCH v4 03/12] refs: pass storage format to `ref_store_init()` explicitly
Message-ID: <CAOLa=ZSRR76Pjzw-S5fYq6pek_cwuhmrpH5QOTkUS4jRhUHZdA@mail.gmail.com>
In-Reply-To: <7d1a86292c205bb47bffa93aa293a3575836f9fb.1717402363.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> We're about to introduce logic to migrate refs from one storage format
> to another one. This will require us to initialize a ref store with a
> different format than the one used by the passed-in repository.
>
> Prepare for this by accepting the desired ref storage format as
> parameter.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  refs.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/refs.c b/refs.c
> index e6db85a165..7c3f4df457 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -1894,13 +1894,14 @@ static struct ref_store *lookup_ref_store_map(struct strmap *map,
>   * gitdir.

Nit: Would be nice to update the documentation here, simply even
s/gitdir/gitdir and ref storage format.

[snip]