From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 10 Sep 2026 13:43:01 GMT
Subject: Re: [PATCH v9 0/4] hook: introduce the receive-report hook
Message-ID: <CAOLa=ZSJOgqiH5wJA7KZ2qPsfyBv21NB6mAwJVX_ZQ7VtWhoAg@mail.gmail.com>
In-Reply-To: <xmqqh5jys5mx.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Patrick Steinhardt <ps@pks.im> writes:
>
>> On Wed, Sep 09, 2026 at 04:51:35PM +0200, Karthik Nayak wrote:
>>> Changes in v9:
>>> - Fix a bug where we were causing a BUG() when no report was requested.
>>>   It is perfectly valid for clients to skip the report and we shouldn't
>>>   fail when they do so. Thanks Junio!
>>
>> It's curious that nothing has failed because of this. Are we lacking
>> tests here?
>
> The "send-pack" client we have will ask for report if the server
> side advertises report-status or report-status-v2 capabilities, and
> there is no way to disable it nor there is no practical need to give
> a way to do so, so unless we are willing to write a custom client,
> or a configuration to disable server capability advertisement, such
> a test is a bit impractical to write.

Yeah, this is kinda the conclusion I came to. I wanted to add in a test
but couldn't see a simple way, so I omitted it.