From: Karthik Nayak <karthik.188@gmail.com>
Date: Wed, 23 Apr 2025 10:03:09 GMT
Subject: Re: [PATCH 03/13] object-store: move and rename `odb_pack_keep()`
Message-ID: <CAOLa=ZS8n+MTG1e=zViEL944yuO_UuqnmT9cTqmTkktHoUiirA@mail.gmail.com>
In-Reply-To: <20250423-pks-object-store-cleanups-v1-3-81f8411a5d08@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> The function `odb_pack_keep()` creates a file at the passed-in path. If
> this fails, then the function re-tries by first creating any potentially
> missing leading directoriesk and then trying to create the file once

s/directoriesk/directories

> again. As such, this function doesn't host any kind of logic that is
> specific to the object store, but is rather a generic helper function.
>
> Rename the function to `safe_create_file_with_leading_directories()` and
> move it into "path.c". While at it, refactor it so that it loses its
> dependency on `the_repository`.
>

Rest of the patch looks good.