From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 19 Aug 2025 09:57:54 GMT
Subject: Re: [PATCH 03/16] odb: move initialization bit into `struct packfile_store`
Message-ID: <CAOLa=ZS4vBPp=2=X98DwEk48qgFMHvM4BecUPayGAK1Wasd3=A@mail.gmail.com>
In-Reply-To: <20250819-b4-pks-packfiles-store-v1-3-1660842e125a@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> diff --git a/packfile.h b/packfile.h
> index 1404b80917..573564b19e 100644
> --- a/packfile.h
> +++ b/packfile.h
> @@ -64,6 +64,12 @@ struct packfile_store {
>  	 * list.
>  	 */
>  	struct packed_git *packs;
> +
> +	/*
> +	 * Whether packfiles have already been populated with this store's
> +	 * packs.
> +	 */
> +	unsigned initialized : 1;
>  };
>

Nit: I know this is moved from existing code, but might be nice to
adhere to our format rules here and remove spaces around the bit field.

Tangent: Also this is something that is only mentioned in the
'.clang-format' but not in any of our documentation, should we add it to
the documentation? Usage seems to be around the same for both types.

>  /*
>
> --
> 2.51.0.261.g7ce5a0a67e.dirty