From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 03 Aug 2015 07:22:31 GMT
Subject: Re: [PATCH v7 0/11] port tag.c to use ref-filter APIs
Message-ID: <CAOLa=ZS1GkN3KHRk2NauC64gye9HOM_LLR0uvDHMDh--UWmrPg@mail.gmail.com>
In-Reply-To: <vpqoaipbnpa.fsf@anie.imag.fr>

On Sun, Aug 2, 2015 at 11:02 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +test_expect_success 'no padding when `padright` length is smaller than atom length' '
>> +    cat >expect <<-\EOF &&
>> +    refs/heads/master|
>> +    refs/heads/side|
>> +    refs/odd/spot|
>> +    refs/tags/double-tag|
>> +    refs/tags/four|
>> +    refs/tags/one|
>> +    refs/tags/signed-tag|
>> +    refs/tags/three|
>> +    refs/tags/two|
>> +    EOF
>> +    git for-each-ref --format="%(padright:5)%(refname)|" >actual &&
>>      test_cmp expect actual
>>  '
>
> Nit: I think the test would be better with padright:15 for example, to
> show that some lines are aligned and some go beyond the 15 columns.
>

I've added something like this :)


-- 
Regards,
Karthik Nayak