From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 17 Aug 2015 19:14:49 GMT
Subject: Re: [PATCH v11 11/13] tag.c: use 'ref-filter' APIs
Message-ID: <CAOLa=ZRxKRsVv5ieJMzxvLUEZRNj-xX7R8-bgi+GaX3y2X9kPA@mail.gmail.com>
In-Reply-To: <xmqq1tf1eo4w.fsf@gitster.dls.corp.google.com>

On Tue, Aug 18, 2015 at 12:30 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> We improve the sorting option provided by 'tag.c' by using the sorting
>> options provided by 'ref-filter'. This causes the test 'invalid sort
>> parameter on command line' in t7004 to fail, as 'ref-filter' throws an
>> error for all sorting fields which are incorrect. The test is changed
>> to reflect the same.
>> ...
>> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
>> index d31788c..1f066aa 100755
>> --- a/t/t7004-tag.sh
>> +++ b/t/t7004-tag.sh
>> @@ -1462,13 +1462,7 @@ test_expect_success 'invalid sort parameter on command line' '
>>
>>  test_expect_success 'invalid sort parameter in configuratoin' '
>>       git config tag.sort "v:notvalid" &&
>> -     git tag -l "foo*" >actual &&
>> -     cat >expect <<-\EOF &&
>> -     foo1.10
>> -     foo1.3
>> -     foo1.6
>> -     EOF
>> -     test_cmp expect actual
>> +     test_must_fail git tag -l "foo*" >actual
>>  '
>
> You don't have to redirect the output to "actual", then.

Ah okay, will remove that. Thanks

-- 
Regards,
Karthik Nayak