From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 25 Aug 2015 10:26:56 GMT
Subject: Re: [PATCH v13 02/12] ref-filter: introduce ref_formatting_state and ref_formatting_stack
Message-ID: <CAOLa=ZRvzM4xyZi09aDrepAZZ9ovKxz08mA9aHjUNpqddfW-8w@mail.gmail.com>
In-Reply-To: <xmqqr3ms2vvh.fsf@gitster.dls.corp.google.com>

On Tue, Aug 25, 2015 at 3:26 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +static void push_new_stack_element(struct ref_formatting_stack **stack)
>> +{
>
> Micronit.  Perhaps s/_new//;, as you do not call the other function
> pop_old_stack_element().
>
> The remainder of this step looks pretty straight-forward and was a
> pleasant read.
>
> Thanks.

Will do, thanks for reviewing :)

-- 
Regards,
Karthik Nayak