From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 30 Jul 2024 14:19:05 GMT
Subject: Re: [PATCH v2 1/5] clang-format: fix indentation width for preprocessor directives
Message-ID: <CAOLa=ZRrUMawq_K=_4OUQrV7V67LhCUrBGtk2G4Z5Zq7+h=hAg@mail.gmail.com>
In-Reply-To: <c33ad700d68b5d8b5940dd803d116ec19bb75c7e.1722323818.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> In [1], we have improved our clang-format configuration to also specify
> the style for how to indent preprocessor directives. But while we have
> settled the question of where to put the indentation, either before or
> after the hash sign, we didn't specify exactly how to indent.
>
> With the current configuration, clang-format uses tabs to indent each
> level of nested preprocessor directives, which is in fact unintentional
> and never done in our codebase. Instead, we use a mixture of indenting
> by either one or two spaces, where using a single space is somewhat more
> common.
>
> Adapt our clang-format configuration accordingly by specifying an
> indentation width of one space.
>
> [1]: <20240708092317.267915-1-karthik.188@gmail.com>
>

I totally missed this, thanks for fixing it up. The patch looks good.