From: Karthik Nayak <karthik.188@gmail.com>
Date: Wed, 15 Jan 2025 16:25:58 GMT
Subject: Re: [PATCH v2 09/10] ci: switch linux-musl to use Meson
Message-ID: <CAOLa=ZRiRWubZJHvzgag8Ypaeye_xzZ9e5bdZxRBQFL_qhzb1Q@mail.gmail.com>
In-Reply-To: <20250114-b4-pks-compat-drop-uncompress2-v2-9-614a2158e34e@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

[snip]

> diff --git a/ci/lib.sh b/ci/lib.sh
> index 8885ee3c3f86c62e8783d27756b8779bd491e7e6..71d85ae85a02e5a4389e133ed53f45a5042af36e 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -378,10 +378,7 @@ linux32)
>  	CC=gcc
>  	;;
>  linux-musl)
> -	CC=gcc

Question: isn't this still needed? I thought there was no way to specify
the default compiler in meson and as such it is better to be explicit
about which compiler we want to use.

> -	MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/python3 USE_LIBPCRE2=Yes"
> -	MAKEFLAGS="$MAKEFLAGS NO_REGEX=Yes ICONV_OMITS_BOM=Yes"
> -	MAKEFLAGS="$MAKEFLAGS GIT_TEST_UTF8_LOCALE=C.UTF-8"
> +	MESONFLAGS="$MESONFLAGS -DGIT_TEST_UTF8_LOCALE=C.UTF-8"
>  	;;
>  linux-leaks|linux-reftable-leaks)
>  	export SANITIZE=leak

[snip]