From: Karthik Nayak <karthik.188@gmail.com>
Date: Fri, 12 Dec 2025 21:29:32 GMT
Subject: Re: What's cooking in git.git (Dec 2025, #02)
Message-ID: <CAOLa=ZRfhKMnnb-4n19Vy0kzBc3QV0df05WNur1_OFa40YssAA@mail.gmail.com>
In-Reply-To: <xmqqwm2uh7gs.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>>>>  Expecting a (hopefully small and final) reroll.
>>>>>  cf. <CAOLa=ZQ-O7V9qHbgeuQ78R1bHGDmGEM6fP5Kr9aC0AfvSF8MZA@mail.gmail.com>
>>>>>  source: <20251121-fix-tags-not-fetching-v8-0-23b53a8a8334@gmail.com>
>>>>
>>>> The only change needed from the last review was a typo. I think we should be
>>>> good as is.
>>>
>>> Meaning that we prefer to leave the typo in, or just we won't die
>>> with a known typo?
>>
>> The typo was in a comment in the tests, so I thought it wasn't worth
>> re-rolling, but happy to do so.
>
> I went back to the discussion to find that single typo and tweaked
> it myself in my tree, so no need to resend.
>
> Thanks.
>
>
> diff --git c/t/t5510-fetch.sh w/t/t5510-fetch.sh
> index a1ca4e1ac7..ce1c23684e 100755
> --- c/t/t5510-fetch.sh
> +++ w/t/t5510-fetch.sh
> @@ -1628,7 +1628,7 @@ test_expect_success "backfill tags when providing a refspec" '
>  	    test_commit fetch-me
>  	) &&
>
> -	# The "history" tag is backfilled eventhough we requested
> +	# The "history" tag is backfilled even though we requested
>  	# to only fetch HEAD
>  	git -C target fetch origin HEAD:branch &&
>  	git -C target tag -l >actual &&

Thanks for handling it. This looks good to me :)