From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 02 Feb 2016 18:50:19 GMT
Subject: Re: [PATCH v4 03/12] ref-filter: bump 'used_atom' and related code to the top
Message-ID: <CAOLa=ZRcsR4t8MEUuMibbN=SLs3PXCpgDhsh3HafAcGLEzHo5Q@mail.gmail.com>
In-Reply-To: <xmqqvb68t6j6.fsf@gitster.mtv.corp.google.com>

On Tue, Feb 2, 2016 at 3:52 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Bump code to the top for usage in further patches.
>> ---
>
> Sign-off?

Shall reply with patch, missed that somehow.

>
>>  ref-filter.c | 30 +++++++++++++++---------------
>>  1 file changed, 15 insertions(+), 15 deletions(-)
>>
>> diff --git a/ref-filter.c b/ref-filter.c
>> index 38f38d4..c3a8372 100644
>> --- a/ref-filter.c
>> +++ b/ref-filter.c
>> @@ -16,6 +16,21 @@
>>
>>  typedef enum { FIELD_STR, FIELD_ULONG, FIELD_TIME } cmp_type;
>>
>> +/*
>> + * An atom is a valid field atom listed below, possibly prefixed with
>> + * a "*" to denote deref_tag().
>> + *
>> + * We parse given format string and sort specifiers, and make a list
>> + * of properties that we need to extract out of objects.  ref_array_item
>> + * structure will hold an array of values extracted that can be
>> + * indexed with the "atom number", which is an index into this
>> + * array.
>> + */
>> +static const char **used_atom;
>> +static cmp_type *used_atom_type;
>> +static int used_atom_cnt, need_tagged, need_symref;
>> +static int need_color_reset_at_eol;
>> +
>>  static struct {
>>       const char *name;
>>       cmp_type cmp_type;
>> @@ -92,21 +107,6 @@ struct atom_value {
>>  };
>>
>>  /*
>> - * An atom is a valid field atom listed above, possibly prefixed with
>> - * a "*" to denote deref_tag().
>> - *
>> - * We parse given format string and sort specifiers, and make a list
>> - * of properties that we need to extract out of objects.  ref_array_item
>> - * structure will hold an array of values extracted that can be
>> - * indexed with the "atom number", which is an index into this
>> - * array.
>> - */
>> -static const char **used_atom;
>> -static cmp_type *used_atom_type;
>> -static int used_atom_cnt, need_tagged, need_symref;
>> -static int need_color_reset_at_eol;
>> -
>> -/*
>>   * Used to parse format string and sort specifiers
>>   */
>>  int parse_ref_filter_atom(const char *atom, const char *ep)



-- 
Regards,
Karthik Nayak