From: Karthik Nayak <karthik.188@gmail.com>
Date: Fri, 17 Jan 2025 09:55:13 GMT
Subject: Re: [PATCH v2 5/5] pack-write: pass hash_algo to internal functions
Message-ID: <CAOLa=ZRaJUHCANv9ot6FbtgYnEDVV3itWnF--0g3NikLZkohmA@mail.gmail.com>
In-Reply-To: <Z4onCYz5zD0L1_Q-@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> On Fri, Jan 17, 2025 at 10:20:52AM +0100, Karthik Nayak wrote:
>> The internal functions `write_rev_trailer()`, `write_rev_trailer()`,
>> `write_mtimes_header()` and write_mtimes_trailer()` use the global
>> `the_hash_algo` variable to access the repository's hash function. Pass
>> the hash from down as we've added made them available in the previous
>
> This doesn't read quite right -- from where do we want to pass it down?
> Other than that the series looks good to me, thanks!
>

I should have s/from//, but let me rephrase it to make it clearer.

Thanks for the review.

> Patrick