From: Karthik Nayak Date: Mon, 24 Aug 2015 18:09:06 GMT Subject: Re: [PATCH v13 00/12] port tag.c to use ref-filter APIs Message-ID: In-Reply-To: On Mon, Aug 24, 2015 at 10:57 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> Interdiff: >> >> diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt >> index 1997657..06d468e 100644 >> --- a/Documentation/git-for-each-ref.txt >> +++ b/Documentation/git-for-each-ref.txt >> @@ -133,7 +133,8 @@ align:: >> `` is either left, right or middle and `` is >> the total length of the content with alignment. If the >> contents length is more than the width then no alignment is >> - performed. >> + performed. If used with '--quote' everything in between %(align:..) >> + and %(end) is quoted. > > That sounds like a buggy behaviour that we may want to fix later, > though. Perhaps document it as a known bug, e.g. "Currently it does > not work well when used with language-specific quoting like --shell, > etc." (while punting on fixing the implementation for now)? > I might have misunderstood you, But based on the discussion held here (thread.gmane.org/gmane.comp.version-control.git/276140) I thought we wanted everything inside the %(align) .... %(end) atoms to be quoted. So I'm a little confused by what you're trying to say. -- Regards, Karthik Nayak