From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 03 Sep 2015 13:49:03 GMT
Subject: Re: [PATCH v15 07/13] ref-filter: add support for %(contents:lines=X)
Message-ID: <CAOLa=ZRSbixzcNyF_s2E+oHMJsG7SuKizb5WHHk5Dmj-OKEetw@mail.gmail.com>
In-Reply-To: <CAOLa=ZRiGg1snfsi_mxQYq-wV6Zz4cTkxum47dRowp1XopQejw@mail.gmail.com>

On Thu, Sep 3, 2015 at 7:04 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>>                         struct strbuf s = STRBUF_INIT;
>>                         if (strtoul_ui(valp, 10, &v->u.contents.lines))
>>                                 die(_("positive width expected contents:lines=%s"), valp);
>> -                       append_lines(&s, subpos, sublen + bodylen - siglen, v->u.contents.lines);
>> +                       append_lines(&s, subpos, bodypos + bodylen - subpos, v->u.contents.lines);
>>                         v->s = strbuf_detach(&s, NULL);
>>                 }
>>         }

append_lines(&s, subpos, bodylen + bodypos - subpos - siglen,
v->u.contents.lines);

We need to eliminate the signature if existing also.

-- 
Regards,
Karthik Nayak