From: Karthik Nayak <karthik.188@gmail.com>
Date: Fri, 26 Jun 2026 14:39:01 GMT
Subject: Re: [PATCH GSoC RFC v13 06/12] connect: refactor packet writing
Message-ID: <CAOLa=ZRR8w2Uaxive8zYyb6fk46rnLuTb-91d2yf=5=Nijzc8g@mail.gmail.com>
In-Reply-To: <xmqqpl1fhesc.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>> +/*
>>> + * Writes a command along with the requested server capabilities/features into a
>>> + * request buffer.
>>> + */
>>>  struct string_list;
>>
>> The comment should be above the function and not the forward
>> declaration.
>>
>> While we're here, why not `#include "string-list.h"` and remove the
>> forward declaration, is there a circular dependency?
>
> Isn't it to avoid unnecessary include?  When the header itself only
> needs to know about the presence of the type, and not the concrete
> shape of the type (e.g., because it only uses a pointer to that
> type), it may be overkill to include the entire header file.

Indeed that seems to be it. Makes sense to me.