From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 18 Jun 2024 09:25:33 GMT
Subject: Re: [PATCH v3 09/20] global: introduce `USE_THE_REPOSITORY_VARIABLE` macro
Message-ID: <CAOLa=ZRA6QDojbvP6btOGX5q1Pa0DivBZA_J1gojF1gJu9aENw@mail.gmail.com>
In-Reply-To: <ZnEYNzLue3OIK-Ul@framework>

Patrick Steinhardt <ps@pks.im> writes:

> On Mon, Jun 17, 2024 at 05:30:31AM -0400, Karthik Nayak wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>> > diff --git a/hash.h b/hash.h
>> > index 39a0164be3..cb85d26a2f 100644
>> > --- a/hash.h
>> > +++ b/hash.h
>> > @@ -4,6 +4,8 @@
>> >  #include "hash-ll.h"
>> >  #include "repository.h"
>> >
>> > -#define the_hash_algo the_repository->hash_algo
>> > +#ifdef USE_THE_REPOSITORY_VARIABLE
>> > +# define the_hash_algo the_repository->hash_algo
>>
>> s/# define/#define/
>
> This is in fact intentional. We aren't strictly following this in our
> codebase, but when nesting preprocessor macros into ifdefs then we often
> indent the inner macros with spaces.
>
> Patrick

That's something I didn't know. Thanks.