From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 13 Oct 2025 09:04:10 GMT
Subject: Re: [PATCH 7/9] reftable/stack: add function to check if optimization is required
Message-ID: <CAOLa=ZR2zOBkS8wQk0=dr-4wU6XR2O-GHV=8LEvzq6F5Bs+tSg@mail.gmail.com>
In-Reply-To: <aOjsgQge8Wqh4odB@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> On Fri, Oct 10, 2025 at 12:27:11PM +0200, Karthik Nayak wrote:
>> The reftable backend for references, performs auto-compaction as part of
>
> s/for references, //
>
>> its regular flow. This allows it to stay optimized.
>
> Maybe: "flow, which is required to keep the number of tables part of a
> stack at bay."
>

Will change.

>> diff --git a/reftable/reftable-stack.h b/reftable/reftable-stack.h
>> index d70fcb705d..754e955206 100644
>> --- a/reftable/reftable-stack.h
>> +++ b/reftable/reftable-stack.h
>> @@ -123,6 +123,9 @@ struct reftable_log_expiry_config {
>>  int reftable_stack_compact_all(struct reftable_stack *st,
>>  			       struct reftable_log_expiry_config *config);
>>
>> +/* check if heuristic based compaction is required  */
>> +int reftable_stack_compaction_required(struct reftable_stack *st, bool *required);
>
> Let's use a full sentence here, starting with an upper-case letter and
> ending with punctuation.
>

Will do.

[snip]