From: karthik nayak <karthik.188@gmail.com>
Date: Wed, 17 Jun 2015 19:49:22 GMT
Subject: Re: [PATCH v3 06/11] ref-filter: implement '--merged' and '--no-merged' options
Message-ID: <CAOLa=ZR1GgWDK71bjmNmgQwEr-nMCFpRmD6yXSijq6z=VXxwow@mail.gmail.com>
In-Reply-To: <vpqoakezq51.fsf@anie.imag.fr>

On Wed, Jun 17, 2015 at 2:08 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>> --- a/ref-filter.c
>> +++ b/ref-filter.c
>> @@ -901,12 +903,19 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,
>>       if (!match_points_at(&filter->points_at, oid->hash, refname))
>>               return 0;
>>
>> +     if (filter->merge_commit) {
>> +             commit = lookup_commit_reference_gently(oid->hash, 1);
>> +             if (!commit)
>> +                     return 0;
>> +     }
>
> I'd appreciate a comment here. If I understand correctly, the comment
> could be along the lines of
>
> /*
>  * A merge filter implies that we're looking at refs pointing to
>  * commits => discard non-commits early. The actual filtering is done
>  * later.
>  */
>
> (perhaps something more concise)
>

Will do add a comment, Thanks!

-- 
Regards,
Karthik Nayak