From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 03 Sep 2015 16:04:45 GMT
Subject: Re: [PATCH v15 07/13] ref-filter: add support for %(contents:lines=X)
Message-ID: <CAOLa=ZQzggAmuAe5_9pjPvqjHquvJtkaKNM5Cbk_ZdQ-cVVWwA@mail.gmail.com>
In-Reply-To: <vpqoahjfsrf.fsf@anie.imag.fr>

On Thu, Sep 3, 2015 at 8:35 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> Also, if 'buf' is indeed unconditionally NUL-terminated, then the (sp
>> <= buf + size) check is wasted code since the result of strstr() will
>> always be either NULL or pointing somewhere within the NUL-terminated
>> string.
>
> The null character is there, but after the signature. buf + size points
> before the signature.
>
> Anyway, all this should go away if Karthik applies my suggestion, which
> I like even more after this discussion ;-).

Yes, your suggestion seems like a good way to go.

-- 
Regards,
Karthik Nayak